Skip to content

Score vs Rank #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
russellpeiris opened this issue Oct 4, 2024 · 3 comments
Closed

Score vs Rank #108

russellpeiris opened this issue Oct 4, 2024 · 3 comments
Assignees
@flemming-n-larsen

Comments

@russellpeiris
Copy link

russellpeiris commented Oct 4, 2024 •
edited
Loading

Total Score does not determine the rank?

Steps to reproduce the behavior:
I simply used the robocode-tankroyale-gui-0.24.4.jar and sample bots.

  1. Set rounds to 2+
  2. Add 3+ bots
  3. See scoreboard

Expected behavior
Highest scorer should receive 1st rank.

Screenshots
image

Desktop (please complete the following information):

  • Windows 11

Java info:
java 17.0.11 2024-04-16 LTS
Java(TM) SE Runtime Environment (build 17.0.11+7-LTS-207)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.11+7-LTS-207, mixed mode, sharing)
@flemming-n-larsen
Copy link
Contributor

@russellpeiris Thank you for the bug report. 🙂👍
Looking at the scores/points, the order of looks correct.
But you are right that the rank is wrong. So I will fix this for the next release. 🙂

flemming-n-larsen added a commit that referenced this issue Oct 8, 2024
@flemming-n-larsen
#108: The ranks were wrong as they did not reflect the total score an…
701dce1 
…d placements
@flemming-n-larsen
Copy link
Contributor

@russellpeiris Fixed for the next release. 🙂

@flemming-n-larsen
Copy link
Contributor

A fix for this issue is included in release 0.25.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flemming-n-larsen flemming-n-larsen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flemming-n-larsen @russellpeiris