Skip to content

fix for issue that it gives error module not found #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2023
Merged

fix for issue that it gives error module not found #22

merged 1 commit into from
Aug 26, 2023

Conversation

luxkatana
Copy link
Contributor

I have reported in the past about a problem that there were some issues with importing modules in the same directory.

I have done a simple fix but I am not sure if it is ready to be merged to the main branch but I think it should work.

The issue

@AsynchronousAI
Copy link
Member

this implementation will probably have to be repeated across all files because they each import their own require.

@luxkatana
Copy link
Contributor Author

this implementation will probably have to be repeated across all files because they each import their own require.

It seems like when running rpyc it just responds without throwing any error.
However I didn't try out yet the other commands.

Copy link
Member

@AsynchronousAI AsynchronousAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks out

@AsynchronousAI AsynchronousAI merged commit f04a9a4 into roblox-compilers:main Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants