Skip to content

refactor(optimizer): refactor agg group key #9390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Apr 24, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@chenzl25 chenzl25 requested review from stdrc and ZENOTME April 24, 2023 06:51
@github-actions github-actions bot added the type/refactor Type: Refactoring. label Apr 24, 2023
@chenzl25 chenzl25 requested a review from st1page April 24, 2023 06:52
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #9390 (fe81fa4) into main (02b3b80) will increase coverage by 0.00%.
The diff coverage is 97.15%.

@@           Coverage Diff           @@
##             main    #9390   +/-   ##
=======================================
  Coverage   70.73%   70.73%           
=======================================
  Files        1228     1227    -1     
  Lines      204122   204118    -4     
=======================================
+ Hits       144378   144386    +8     
+ Misses      59744    59732   -12     
Flag Coverage Δ
rust 70.73% <97.15%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/optimizer/logical_optimization.rs 95.63% <ø> (-0.07%) ⬇️
src/frontend/src/optimizer/plan_node/stream.rs 14.22% <0.00%> (ø)
src/frontend/src/optimizer/rule/mod.rs 100.00% <ø> (ø)
...frontend/src/optimizer/plan_node/batch_sort_agg.rs 78.40% <75.00%> (+0.76%) ⬆️
...frontend/src/optimizer/plan_node/batch_hash_agg.rs 84.31% <90.00%> (+4.70%) ⬆️
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 84.35% <96.15%> (+0.11%) ⬆️
...ontend/src/optimizer/plan_node/batch_simple_agg.rs 81.25% <100.00%> (ø)
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 95.51% <100.00%> (-0.23%) ⬇️
...rontend/src/optimizer/plan_node/stream_hash_agg.rs 98.19% <100.00%> (ø)
...src/optimizer/plan_node/stream_local_simple_agg.rs 93.54% <100.00%> (ø)
... and 7 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ZENOTME ZENOTME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzl25 chenzl25 added this pull request to the merge queue Apr 24, 2023
Merged via the queue into main with commit bc05eaf Apr 24, 2023
@chenzl25 chenzl25 deleted the dylan/refactor_agg_group_key branch April 24, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/refactor Type: Refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use a set instead of vec to represent the group-by clause in the Agg operator
4 participants