Skip to content

refactor(optimizer): refactor the column index mapping's inverse method #9252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

chenzl25
Copy link
Contributor

@chenzl25 chenzl25 commented Apr 18, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/refactor Type: Refactoring. label Apr 18, 2023
@chenzl25 chenzl25 requested review from st1page, BugenZhao and xiangjinwu and removed request for st1page April 18, 2023 09:34
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #9252 (b6b7330) into main (23a8333) will decrease coverage by 0.01%.
The diff coverage is 92.15%.

@@            Coverage Diff             @@
##             main    #9252      +/-   ##
==========================================
- Coverage   70.79%   70.79%   -0.01%     
==========================================
  Files        1216     1216              
  Lines      202127   202159      +32     
==========================================
+ Hits       143101   143123      +22     
- Misses      59026    59036      +10     
Flag Coverage Δ
rust 70.79% <92.15%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/optimizer/plan_node/generic/expand.rs 85.54% <0.00%> (-2.12%) ⬇️
src/common/src/util/column_index_mapping.rs 73.65% <80.00%> (-0.24%) ⬇️
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 84.39% <100.00%> (+0.11%) ⬆️
...tend/src/optimizer/plan_node/generic/hop_window.rs 93.12% <100.00%> (+0.05%) ⬆️
...c/frontend/src/optimizer/plan_node/generic/join.rs 94.28% <100.00%> (+0.06%) ⬆️
...rontend/src/optimizer/plan_node/generic/project.rs 99.51% <100.00%> (+0.01%) ⬆️
...end/src/optimizer/plan_node/generic/project_set.rs 100.00% <100.00%> (ø)
...c/frontend/src/optimizer/plan_node/logical_scan.rs 96.11% <100.00%> (+<0.01%) ⬆️
...nd/src/optimizer/rule/apply_join_transpose_rule.rs 89.39% <100.00%> (+0.06%) ⬆️
...ontend/src/optimizer/rule/apply_offset_rewriter.rs 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzl25 chenzl25 added this pull request to the merge queue Apr 19, 2023
Merged via the queue into main with commit 1fd0394 Apr 19, 2023
@chenzl25 chenzl25 deleted the dylan/refactor_col_mapping_inverse branch April 19, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/refactor Type: Refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review existing usages of the inverse method of ColIndexMapping
2 participants