Skip to content

fix(compaction group): trivial adjust should also increase divide ver… #8484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2023
Merged

fix(compaction group): trivial adjust should also increase divide ver… #8484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a12211
fix(compaction group): trivial adjust should also increase divide ver…
Mar 11, 2023
bdad000
unit test
Mar 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/meta/src/hummock/manager/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,8 +1510,8 @@ async fn test_split_compaction_group_on_demand_basic() {
.get(&new_group_id)
.cloned()
.unwrap(),
0,
"trivial adjust doesn't increase divide version"
1,
"trivial adjust should aoso increase divide version"
);
}
}
Expand Down
4 changes: 1 addition & 3 deletions src/storage/hummock_sdk/src/compaction_group/hummock_version_ext.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,7 @@ impl HummockVersionUpdateExt for HummockVersion {
.get_table_ids()
.iter()
.all(|table_id| member_table_ids.contains(table_id));
if !is_trivial {
sst_info.divide_version += 1;
}
sst_info.divide_version += 1;
split_id_vers.push((
sst_info.get_id(),
sst_info.get_divide_version(),
Expand Down