Skip to content

refactor(streaming): top_n managed state use impl Row2 #6480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 21, 2022

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Nov 21, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

#6404 has introduced row trait, and StateTable insert/delete with impl Row2. This PR changes top_n managed state insert function to pass RowRef instead of Row.

Note that as we have not think clearly how to handle CompactedRow and Row2, it's hard for top_n managed state to delete RowRef now.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the type/refactor Type: Refactoring. label Nov 21, 2022
@wcy-fdu wcy-fdu requested a review from BugenZhao November 21, 2022 06:37
@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #6480 (adee9d2) into main (709e1be) will increase coverage by 0.06%.
The diff coverage is 81.42%.

@@            Coverage Diff             @@
##             main    #6480      +/-   ##
==========================================
+ Coverage   73.94%   74.00%   +0.06%     
==========================================
  Files         981      983       +2     
  Lines      159159   160712    +1553     
==========================================
+ Hits       117690   118940    +1250     
- Misses      41469    41772     +303     
Flag Coverage Δ
rust 74.00% <81.42%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/row_seq_scan.rs 20.00% <0.00%> (-0.21%) ⬇️
src/batch/src/lib.rs 100.00% <ø> (ø)
src/frontend/src/handler/variable.rs 0.00% <0.00%> (ø)
...ntend/src/optimizer/plan_node/stream_index_scan.rs 41.40% <0.00%> (-0.33%) ⬇️
src/frontend/src/session.rs 40.36% <0.00%> (ø)
src/source/src/lib.rs 90.00% <ø> (ø)
src/source/src/parser/common.rs 63.63% <ø> (ø)
src/sqlparser/src/keywords.rs 100.00% <ø> (ø)
src/storage/src/hummock/event_handler/mod.rs 0.00% <ø> (ø)
src/storage/src/hummock/local_version/mod.rs 100.00% <ø> (ø)
... and 97 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcy-fdu wcy-fdu requested a review from BugenZhao November 21, 2022 07:16
@wcy-fdu wcy-fdu changed the title refactor(streaming): top_n managed state insert row_ref refactor(streaming): top_n managed state use impl Row2 Nov 21, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 21, 2022

Hey @wcy-fdu, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with git commit --allow-empty -m "rerun" && git push.

@mergify mergify bot merged commit 213da6a into main Nov 21, 2022
@mergify mergify bot deleted the wcy/row_trait_for_executor branch November 21, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/refactor Type: Refactoring.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants