-
Notifications
You must be signed in to change notification settings - Fork 664
refactor(streaming): top_n managed state use impl Row2 #6480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6480 +/- ##
==========================================
+ Coverage 73.94% 74.00% +0.06%
==========================================
Files 981 983 +2
Lines 159159 160712 +1553
==========================================
+ Hits 117690 118940 +1250
- Misses 41469 41772 +303
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hey @wcy-fdu, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by clicking "Update branch" or pushing an empty commit with |
…into wcy/row_trait_for_executor
…larity-data/risingwave into wcy/row_trait_for_executor
…wave into zehua/reduce_meta_snapshot_lock
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
#6404 has introduced row trait, and
StateTable
insert/delete withimpl Row2
. This PR changes top_n managed state insert function to passRowRef
instead ofRow
.Note that as we have not think clearly how to handle
CompactedRow
andRow2
, it's hard for top_n managed state to deleteRowRef
now.Checklist
./risedev check
(or alias,./risedev c
)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)