Skip to content

feat(stream): one small step for watermark #6063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 27, 2022

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Oct 26, 2022

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

introduce the watermark in the proto and stream message

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Refer to a related PR or issue link (optional)

#6043

@github-actions github-actions bot added the type/feature Type: New feature. label Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #6063 (5b30949) into main (23ca731) will decrease coverage by 0.02%.
The diff coverage is 34.00%.

@@            Coverage Diff             @@
##             main    #6063      +/-   ##
==========================================
- Coverage   74.63%   74.60%   -0.03%     
==========================================
  Files         930      930              
  Lines      148422   148434      +12     
==========================================
- Hits       110772   110739      -33     
- Misses      37650    37695      +45     
Flag Coverage Δ
rust 74.60% <34.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/barrier_align.rs 98.63% <ø> (-1.37%) ⬇️
src/stream/src/executor/chain.rs 89.88% <ø> (ø)
src/stream/src/executor/dispatch.rs 72.50% <0.00%> (-0.10%) ⬇️
src/stream/src/executor/global_simple_agg.rs 95.55% <ø> (ø)
src/stream/src/executor/hash_agg.rs 97.23% <ø> (+0.15%) ⬆️
src/stream/src/executor/hash_join.rs 97.50% <0.00%> (-0.09%) ⬇️
src/stream/src/executor/integration_tests.rs 98.42% <ø> (ø)
src/stream/src/executor/local_simple_agg.rs 93.59% <ø> (ø)
src/stream/src/executor/lookup/sides.rs 25.00% <ø> (-4.17%) ⬇️
src/stream/src/executor/lookup_union.rs 84.69% <ø> (ø)
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yuhao-su
Copy link
Contributor

LGTM!

@yuhao-su yuhao-su marked this pull request as ready for review October 27, 2022 05:16
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao requested a review from fuyufjh October 27, 2022 05:36
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit bd8fb46 into main Oct 27, 2022
@mergify mergify bot deleted the sts_one_small_step_for_watermark branch October 27, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Type: New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants