fix(common): order null as largest by default to align with PostgreSQL #4263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` NEXTEST_EXPERIMENTAL_FILTER_EXPR=1 ./risedev test -E 'not test(~lookup_join)' ```
xiangjinwu
added
the
user-facing-changes
Codecov Report
@@ Coverage Diff @@
## main #4263 +/- ##
==========================================
- Coverage 74.38% 74.37% -0.01%
==========================================
Files 842 842
Lines 121509 121511 +2
==========================================
- Hits 90381 90379 -2
- Misses 31128 31132 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lmatz
approved these changes
Jul 28, 2022
|
Rust’s Option is null-first by default. I guess some BTreeMap cache storing OptionT is still having a wrong behavior. We should take some time to revisit them. |
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
risingwavelabs#4263) * encode and decode null as largest in memcomparable encoding * fix unit test except lookup join ``` NEXTEST_EXPERIMENTAL_FILTER_EXPR=1 ./risedev test -E 'not test(~lookup_join)' ``` * update lookup join unit test * update e2e * update batch ordering of null * update e2e Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Without
nulls firstornulls last, which we do not support yet, PostgreSQL treatsnullas largest value, while we have been treating it as the smallest.null_tagis flipped. That is,nullencodes and decodes as1rather than0.Checklist
./risedev check(or alias,./risedev c)Documentation
Types of user-facing changes
Release note
When ordering on a column containing null values, our behavior is now same as PostgreSQL. That is,
nullis treated as larger than any other value.Refer to a related PR or issue link (optional)
Fixes #3204