Skip to content

feat: support ALTER CONNECTION CONNECTOR WITH #22563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: tab/alter-connection-1
Choose a base branch
from

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Jul 10, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

pending for #22496

Description:
This PR introduces support for altering certain Kafka connection properties on the fly using the ALTER CONNECTION ... CONNECTOR WITH SQL statement. The following changes are included:

  • New E2E Test:
    Added e2e_test/ddl/alter_connection_connector_props.slt to verify the behavior of altering connection properties, including secret management, error cases, and dependent object validation.

  • Connector Logic Update:

    • Introduced CONNECTION_ALLOW_ALTER_ON_FLY_FIELDS to specify which connection fields can be altered without dropping/recreating the connection.
    • Implemented check_connection_allow_alter_on_fly_fields to validate allowed fields for connection alteration.
    • Added get_connection_names_with_allow_alter_on_fly_fields for introspection.
    • Updated macros to map connection names to their type names for property validation.
  • Test and Validation Enhancements:

    • Extended connector property validation and test coverage for connection alteration.
    • Ensured that dependent sources and sinks continue to function after connection properties are altered.
    • Added error handling for disallowed or unknown field alterations.

These changes improve the flexibility and manageability of Kafka connections in RisingWave, allowing for secure and controlled updates to connection properties without service interruption.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant