feat(iceberg): introduce small file compaction #22527
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type/feature
hzxa21
changed the title
chenzl25
approved these changes
Jul 10, 2025
…nto li0k/iceberg-small-file-compact
chenzl25
approved these changes
Jul 15, 2025
Comment on lines
+1696
to
+1701
|
|
||
| if table.append_only { | ||
| sink_with.insert("type".to_owned(), "append-only".to_owned()); | ||
| } else { | ||
| sink_with.insert("type".to_owned(), "upsert".to_owned()); | ||
| } |
There was a problem hiding this comment.
For append_only iceberg table, we should remove the sink_with.insert("primary_key".to_owned(), pks.join(","));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR introduces Small Data File Compaction and modifies the default behavior of the append-only Iceberg sink. It switches the default from Full Compaction to Small Data File Compaction to reduce write amplification and space amplification.
Checklist
Documentation
Release note