-
Notifications
You must be signed in to change notification settings - Fork 633
feat(expr): implement array_flatten
#21640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,96 @@ | ||
// Copyright 2025 RisingWave Labs | ||
// | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
// Unless required by applicable law or agreed to in writing, software | ||
// distributed under the License is distributed on an "AS IS" BASIS, | ||
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
// See the License for the specific language governing permissions and | ||
// limitations under the License. | ||
|
||
use risingwave_common::array::{ListRef, ListValue}; | ||
use risingwave_expr::expr::Context; | ||
use risingwave_expr::{ExprError, Result, function}; | ||
|
||
/// Flattens a nested array by concatenating the inner arrays into a single array. | ||
/// Only the outermost level of nesting is removed. For deeper nested arrays, call | ||
/// `array_flatten` multiple times. | ||
/// | ||
/// Examples: | ||
/// | ||
/// ```slt | ||
/// query T | ||
/// select array_flatten(array[array[1, 2], array[3, 4]]); | ||
/// ---- | ||
/// {1,2,3,4} | ||
/// | ||
/// query T | ||
/// select array_flatten(array[array[1, 2], array[]::int[], array[3, 4]]); | ||
/// ---- | ||
/// {1,2,3,4} | ||
/// | ||
/// query T | ||
/// select array_flatten(array[array[1, 2], null, array[3, 4]]); | ||
/// ---- | ||
/// {1,2,3,4} | ||
/// | ||
/// query T | ||
/// select array_flatten(array[array[array[1], array[2, null]], array[array[3, 4], null::int[]]]); | ||
/// ---- | ||
/// {{1},{2,NULL},{3,4},NULL} | ||
/// | ||
/// query T | ||
/// select array_flatten(array[[]]::int[][]); | ||
/// ---- | ||
/// {} | ||
/// | ||
/// query T | ||
/// select array_flatten(array[[null, 1]]::int[][]); | ||
/// ---- | ||
/// {NULL,1} | ||
/// | ||
/// query T | ||
/// select array_flatten(array[]::int[][]); | ||
/// ---- | ||
/// {} | ||
/// | ||
/// query T | ||
/// select array_flatten(null::int[][]); | ||
/// ---- | ||
/// NULL | ||
/// ``` | ||
#[function("array_flatten(anyarray) -> anyarray")] | ||
fn array_flatten(array: ListRef<'_>, ctx: &Context) -> Result<ListValue> { | ||
// The elements of the array must be arrays themselves | ||
let outer_type = &ctx.arg_types[0]; | ||
let inner_type = if outer_type.is_array() { | ||
outer_type.as_list() | ||
} else { | ||
return Err(ExprError::InvalidParam { | ||
name: "array_flatten", | ||
reason: Box::from("expected the argument to be an array of arrays"), | ||
}); | ||
}; | ||
if !inner_type.is_array() { | ||
return Err(ExprError::InvalidParam { | ||
name: "array_flatten", | ||
reason: Box::from("expected the argument to be an array of arrays"), | ||
}); | ||
} | ||
let inner_elem_type = inner_type.as_list(); | ||
|
||
// Collect all inner array elements and flatten them into a single array | ||
Ok(ListValue::from_datum_iter( | ||
inner_elem_type, | ||
array | ||
.iter() | ||
// Filter out NULL inner arrays | ||
.flatten() | ||
// Flatten all inner arrays | ||
.flat_map(|inner_array| inner_array.into_list().iter()), | ||
)) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized
array_flatten(arr)
is equivalent togenuine_array_concat(VARIADIC arr)
. However:genuine_array_concat
is different from PostgreSQL/RisingWavearray_cat
, which has a wired behavior on >= 2d array due to its weak array typing (int[][]
is same asint[]
)VARIADIC
as separate exprs but in PostgreSQL there is a singleconcat_ws
/jsonb_extract_path
Just sharing some related ideas. Nothing to change in this PR.