revert: "test: run fe stack overflow test only in release mode" #21454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ff2e75.
xxchan
changed the title
xxchan
changed the title
kwannoel
reviewed
Apr 17, 2025
| @@ -1,5 +1,3 @@ | |||
| # Why this is release mode only: https://github.com/risingwavelabs/risingwave/issues/21355#issuecomment-2806876248 | |||
There was a problem hiding this comment.
Can we keep link to issue? So if we encounter some regression again, we have a starting point to debug.
BugenZhao
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #21424
#21424 (comment)
Although I think if the test fail in dev mode, it's a not big deal. But this might be a good way to track increased memory usage in frontend. (until we cannot manage it...)
related #21355