fix: double RUST_MIN_STACK to resolve stack overflow #19695
Conversation
|
qq: Can we also change the risedev test command with RUST_MIN_STACK ? |
Makefile.toml
Outdated
| set_env RW_TEMP_SECRET_FILE_DIR "${PREFIX_SECRET}" | ||
| set_env RUST_MIN_STACK 8388608 |
There was a problem hiding this comment.
@Li0k risedev command utilizes the Makefile here. So it has been applied to risedev test
There was a problem hiding this comment.
I suggest not touching this, or at least only set if it's unset.
There was a problem hiding this comment.
But running risedev test locally also fails. I am afraid we cannot accept this.
There was a problem hiding this comment.
I am afraid we cannot accept this.
Yeah, so I suggest #19695 (review) 🥺
There was a problem hiding this comment.
Yes, I am checking the PR you mentioned.
Signed-off-by: tabVersion <[email protected]>
|
Setting RUST_MIN_STACK to 8388608 (8MB) just when running |
Signed-off-by: tabversion <[email protected]>
Co-authored-by: stonepage <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
when running SQL planner test, we meet a stack overflow panic https://buildkite.com/risingwavelabs/pull-request/builds/63818#0193962f-47f4-484f-bd3e-21aa7aa25ae5
and same observation by @Li0k
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.