Skip to content

fix: udf error ui #18118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024
Merged

fix: udf error ui #18118

merged 1 commit into from
Aug 20, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc stdrc requested a review from lmatz August 20, 2024 03:55
@github-actions github-actions bot added the type/fix Bug fix label Aug 20, 2024
@lmatz lmatz added need-cherry-pick-release-1.10 [⚠️DEPRECATED] Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 [⚠️DEPRECATED] Use `..-since-release-..` instead labels Aug 20, 2024
@stdrc stdrc enabled auto-merge August 20, 2024 03:59
@stdrc stdrc disabled auto-merge August 20, 2024 04:00
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc changed the base branch from release-1.10 to main August 20, 2024 04:05
@stdrc stdrc requested a review from a team as a code owner August 20, 2024 04:05
@stdrc stdrc requested a review from xxchan August 20, 2024 04:05
@graphite-app graphite-app bot requested a review from a team August 20, 2024 04:06
@stdrc stdrc force-pushed the rc/fix-udf-error-ui branch from 45693e1 to b83880c Compare August 20, 2024 04:06
@stdrc stdrc removed request for a team and xxchan August 20, 2024 04:06
@stdrc stdrc enabled auto-merge August 20, 2024 04:18
@stdrc stdrc added this pull request to the merge queue Aug 20, 2024
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why CI didn’t prevent the regression? Is this a flaky test..?

@graphite-app graphite-app bot requested a review from a team August 20, 2024 04:42
@stdrc
Copy link
Member Author

stdrc commented Aug 20, 2024

Why CI didn’t prevent the regression? Is this a flaky test..?

I believe this can be caused by CI infra's network configuration change.

Merged via the queue into main with commit 747245f Aug 20, 2024
29 of 30 checks passed
@stdrc stdrc deleted the rc/fix-udf-error-ui branch August 20, 2024 04:53
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
Signed-off-by: Richard Chien <[email protected]>
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
Signed-off-by: Richard Chien <[email protected]>
@stdrc
Copy link
Member Author

stdrc commented Aug 20, 2024

Why CI didn’t prevent the regression? Is this a flaky test..?

Another CI test produced the old message: https://buildkite.com/risingwavelabs/pull-request/builds/56040#01916e22-fdda-4a17-aea8-bbd6e32453b0

I guess this is related to the network setup of the spot instance allocated for the CI pipeline.

Is it possible to support only to check the first several lines of the error message in sqllogictest?

@stdrc
Copy link
Member Author

stdrc commented Aug 20, 2024

StrikeW pushed a commit that referenced this pull request Aug 20, 2024
Signed-off-by: Richard Chien <[email protected]>
@StrikeW
Copy link
Contributor

StrikeW commented Aug 20, 2024

@stdrc stdrc mentioned this pull request Aug 20, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 [⚠️DEPRECATED] Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 [⚠️DEPRECATED] Use `..-since-release-..` instead type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants