Skip to content

fix: not bail! on kinesis's state if scan.startup.mode set to timestamp #18038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

introduced in #12048

the create split gonna fail

  • if user set scan.startup.mode to timestamp
  • a new shard is discovered and ready to consume

-> lead to create source task failure

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion requested review from stdrc and fuyufjh August 14, 2024 06:55
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Aug 14, 2024
@tabVersion tabVersion added the need-cherry-pick-release-1.10 [⚠️DEPRECATED] Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Aug 14, 2024
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion enabled auto-merge August 14, 2024 06:59
Signed-off-by: tabVersion <[email protected]>
@tabVersion
Copy link
Contributor Author

@stdrc talked about enumerator should inherent offset settings from source props. But it cannot handle the case if the user set scan.startup.mode to latest, leading to data loss from the shard starts to the time we actually start reading data.

Merged via the queue into main with commit be6b3a7 Aug 14, 2024
29 of 30 checks passed
@tabVersion tabVersion deleted the tab/kinesis-fix-reader branch August 14, 2024 08:18
tabVersion added a commit that referenced this pull request Sep 19, 2024
@tabVersion
Copy link
Contributor Author

#18040
the pr labeled with cherry-pick-release-1.10 but actually picked to release-1.9 🤣

github-merge-queue bot pushed a commit that referenced this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 [⚠️DEPRECATED] Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants