-
Notifications
You must be signed in to change notification settings - Fork 640
fix: not bail!
on kinesis's state if scan.startup.mode
set to timestamp
#18038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
stdrc
approved these changes
Aug 14, 2024
Signed-off-by: tabVersion <[email protected]>
9 tasks
lmatz
pushed a commit
that referenced
this pull request
Aug 14, 2024
…mp (#18038) (#18040) Signed-off-by: tabVersion <[email protected]>
@stdrc talked about enumerator should inherent offset settings from source props. But it cannot handle the case if the user set |
fuyufjh
approved these changes
Aug 14, 2024
tabVersion
added a commit
that referenced
this pull request
Sep 19, 2024
…mestamp` (#18038) Signed-off-by: tabVersion <[email protected]>
9 tasks
#18040 |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: tabVersion <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need-cherry-pick-release-1.10
[⚠️DEPRECATED] Open a cherry-pick PR to branch release-1.10 after the current PR is merged
type/fix
Type: Bug fix. Only for pull requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
introduced in #12048
the create split gonna fail
scan.startup.mode
totimestamp
-> lead to create source task failure
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.