Skip to content

feat(catalog): support DBeaver constraints view #15227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 26, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Feb 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Implemented pg_catalog.pg_constraint. Only primary keys are listed because this is the only constraints supported in RisingWave.

closes #15197
closes #15205

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

(No need to update any docs page)

  • Support pg_catalog.pg_constraint for DBeaver compatibility.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, generation_expression and is_generated has been added in rw_columns, you may need to resolve the conflict.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just restructured code to reduce indent.

@fuyufjh fuyufjh added this pull request to the merge queue Feb 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 26, 2024
@fuyufjh fuyufjh added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit d50b4cb Feb 26, 2024
@fuyufjh fuyufjh deleted the eric/fix_dbeaver_constraints branch February 26, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: DBeaver: Invalid column: relpartbound Add info about primary keys in the pg_catalog.pg_constraint view
2 participants