Skip to content

feat(frontend): support tab-completion for [ALTER SYSTEM] SET #15123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Feb 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Based on #15113 and #15108. Resolve #8850.


Note that the session variables is always a subset of system parameters in Postgres' configuration system (Grand Unified Configuration, GUC), which does not hold in RisingWave.

As a result, psql will also auto-complete session variables for ALTER SYSTEM SET that are false positives. There's no elegant way to fix that as the query for auto-completion is automatically sent by the client. However, this is not a significant issue so we may simply leave it as it is.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Support tab-completion for SET and ALTER SYSTEM SET commands in psql client.

Copy link
Member Author

BugenZhao commented Feb 19, 2024

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@BugenZhao BugenZhao changed the title introduce context feat(frontend): support tab-completion for [ALTER SYSTEM] SET Feb 19, 2024
@BugenZhao BugenZhao marked this pull request as ready for review February 19, 2024 05:47
@BugenZhao BugenZhao added the user-facing-changes Contains changes that are visible to users label Feb 19, 2024
@BugenZhao BugenZhao requested a review from yuhao-su February 19, 2024 05:59
Base automatically changed from bz/refine-show-parameters to main February 19, 2024 08:36
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao force-pushed the bz/pg-settings-tab-completion branch from 51a0edd to 28364c9 Compare February 19, 2024 08:40
@BugenZhao BugenZhao enabled auto-merge February 19, 2024 08:43
@BugenZhao BugenZhao added this pull request to the merge queue Feb 19, 2024
Merged via the queue into main with commit 1cbb87b Feb 19, 2024
@BugenZhao BugenZhao deleted the bz/pg-settings-tab-completion branch February 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support psql tab-completion for variables & system parameters
3 participants