Skip to content

feat: add kafka props enable.ssl.certificate.verification #15073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/connector/src/common.rs
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,10 @@ pub struct RdKafkaPropertiesCommon {
#[serde(rename = "properties.client.id")]
#[serde_as(as = "Option<DisplayFromStr>")]
pub client_id: Option<String>,

#[serde(rename = "properties.enable.ssl.certificate.verification")]
#[serde_as(as = "Option<DisplayFromStr>")]
pub enable_ssl_certificate_verification: Option<bool>,
}

impl RdKafkaPropertiesCommon {
Expand All @@ -275,6 +279,9 @@ impl RdKafkaPropertiesCommon {
if let Some(v) = self.client_id.as_ref() {
c.set("client.id", v);
}
if let Some(v) = self.enable_ssl_certificate_verification {
c.set("enable.ssl.certificate.verification", v.to_string());
}
}
}

Expand Down
3 changes: 3 additions & 0 deletions src/connector/with_options_sink.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,9 @@ KafkaConfig:
field_type: String
comments: Client identifier
required: false
- name: properties.enable.ssl.certificate.verification
field_type: bool
required: false
- name: properties.allow.auto.create.topics
field_type: bool
comments: Allow automatic topic creation on the broker when subscribing to or assigning non-existent topics.
Expand Down
3 changes: 3 additions & 0 deletions src/connector/with_options_source.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,9 @@ KafkaProperties:
field_type: String
comments: Client identifier
required: false
- name: properties.enable.ssl.certificate.verification
field_type: bool
required: false
- name: properties.queued.min.messages
field_type: usize
comments: Minimum number of messages per topic+partition librdkafka tries to maintain in the local consumer queue.
Expand Down