Skip to content

fix: add clang to dockerfile #14777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

fix: add clang to dockerfile #14777

merged 1 commit into from
Jan 24, 2024

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#14761 introduced a clang dependency at build time. It was missing in the main dockerfile.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Signed-off-by: Runji Wang <[email protected]>
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Jan 24, 2024
@MrCroxx MrCroxx added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit 040ea58 Jan 24, 2024
@MrCroxx MrCroxx deleted the wrj/fix-rquickjs-on-arm-linux branch January 24, 2024 11:43
@BugenZhao
Copy link
Member

The docker build succeeded, but the release job started to fail. 😕

https://buildkite.com/risingwavelabs/docker/builds/15062#_

@huangjw806
Copy link
Contributor

The docker build succeeded, but the release job started to fail. 😕

https://buildkite.com/risingwavelabs/docker/builds/15062#_

I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants