-
Notifications
You must be signed in to change notification settings - Fork 637
feat(source): support json schema #11797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11797 +/- ##
==========================================
- Coverage 70.21% 70.20% -0.02%
==========================================
Files 1373 1373
Lines 228741 228886 +145
==========================================
+ Hits 160621 160688 +67
- Misses 68120 68198 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Is schema registry is required for JSON format after this pr? IIRC, we have a conclusion before that schema registry is required for Avro format. cc @neverchanje |
It's an option. We still support JSON format in old way. |
It is not required. We implement it at a poc user's request. |
planner_error: 'Invalid input syntax: schema definition is required for ENCODE JSON' | ||
planner_error: 'Protocol error: missing field ''connector''' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@st1page please double check the change.
I don't see how you handle this situation. |
jsonschema-transpiler does not support this based on my testing. |
Performance
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically LGTM, waiting @st1page for syntax check.
This PR introduces too many outdated and unnecessary dependencies to our workspace, including |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support json schema as schema registry. Syntax is
Basic idea is to use jsonschema-transpiler to generate avro schema from json schema.
Redpanda does not support json schema yet (see redpanda-data/redpanda#1878). So kafka is used here as workaround.
References outside the schema is not supported yet.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.