Skip to content

fix: remove decoding message size limit in telemetry and connector grpc client #11758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Aug 17, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Known issue after tonic upgrade. Now it hits connector grpc client. This PR remove the limit for connector and telemetry grpc client.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Aug 17, 2023
@hzxa21 hzxa21 enabled auto-merge August 17, 2023 10:21
@hzxa21 hzxa21 added this pull request to the merge queue Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #11758 (0be647b) into main (7a16325) will increase coverage by 0.00%.
Report is 21 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #11758   +/-   ##
=======================================
  Coverage   70.36%   70.36%           
=======================================
  Files        1365     1365           
  Lines      228221   228222    +1     
=======================================
+ Hits       160577   160583    +6     
+ Misses      67644    67639    -5     
Flag Coverage Δ
rust 70.36% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/rpc_client/src/connector_client.rs 11.26% <0.00%> (ø)
src/rpc_client/src/meta_client.rs 4.09% <0.00%> (-0.01%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 0874a48 Aug 17, 2023
@hzxa21 hzxa21 deleted the patrick/tnoic-message-size branch August 17, 2023 11:05
lmatz pushed a commit that referenced this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Type: Bug fix. Only for pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants