Skip to content

feat: (step 3.1) enable builtin view for some dummy and simple system catalogs #11278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2023

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Jul 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Related #11005 .

  1. introduced infer_dummy_view_sql to rewrite some dummy pg catalogs as views.
  2. enable binding system views for binder.
  3. rewrite some simple pg system catalogs to views upon rw system tables.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Merging #11278 (db1c3ea) into main (e9ba60a) will increase coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 97.32%.

@@            Coverage Diff             @@
##             main   #11278      +/-   ##
==========================================
+ Coverage   69.66%   69.75%   +0.09%     
==========================================
  Files        1357     1357              
  Lines      224929   224997      +68     
==========================================
+ Hits       156700   156956     +256     
+ Misses      68229    68041     -188     
Flag Coverage Δ
rust 69.75% <97.32%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...alog/system_catalog/rw_catalog/rw_relation_info.rs 0.00% <ø> (ø)
...rc/frontend/src/binder/relation/table_or_source.rs 79.65% <75.00%> (+0.14%) ⬆️
src/frontend/src/catalog/schema_catalog.rs 47.91% <75.00%> (+0.77%) ⬆️
src/frontend/src/catalog/root_catalog.rs 61.03% <100.00%> (+3.02%) ⬆️
src/frontend/src/catalog/system_catalog/mod.rs 58.85% <100.00%> (+11.85%) ⬆️
...end/src/catalog/system_catalog/pg_catalog/pg_am.rs 100.00% <100.00%> (+100.00%) ⬆️
...rc/catalog/system_catalog/pg_catalog/pg_attrdef.rs 100.00% <100.00%> (+100.00%) ⬆️
.../catalog/system_catalog/pg_catalog/pg_collation.rs 100.00% <100.00%> (+100.00%) ⬆️
...catalog/system_catalog/pg_catalog/pg_constraint.rs 100.00% <100.00%> (+8.10%) ⬆️
...catalog/system_catalog/pg_catalog/pg_conversion.rs 100.00% <100.00%> (+100.00%) ⬆️
... and 16 more

... and 11 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yezizp2012 yezizp2012 requested a review from xiangjinwu July 28, 2023 03:39
@yezizp2012 yezizp2012 enabled auto-merge July 28, 2023 07:48
@yezizp2012 yezizp2012 added this pull request to the merge queue Jul 28, 2023
Merged via the queue into main with commit 33f0cc2 Jul 28, 2023
@yezizp2012 yezizp2012 deleted the refactor/sys-table-step3.1 branch July 28, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants