Skip to content

feat: enable verbose await-tree by default in production #10144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2023

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jun 2, 2023

Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Enable verbose await-tree by default in production. Also add some more instruments.

Benchmarking...


No performance regression found!

image

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

BugenZhao added 2 commits June 2, 2023 16:41
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@github-actions github-actions bot added the type/feature Type: New feature. label Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #10144 (e57bb31) into main (fe04858) will decrease coverage by 0.01%.
The diff coverage is 8.33%.

@@            Coverage Diff             @@
##             main   #10144      +/-   ##
==========================================
- Coverage   70.90%   70.89%   -0.01%     
==========================================
  Files        1234     1234              
  Lines      211071   211088      +17     
==========================================
+ Hits       149652   149654       +2     
- Misses      61419    61434      +15     
Flag Coverage Δ
rust 70.89% <8.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/compute/src/server.rs 0.00% <0.00%> (ø)
src/expr/src/expr/expr_udf.rs 0.00% <0.00%> (ø)
src/storage/src/monitor/monitored_store.rs 4.11% <0.00%> (-0.11%) ⬇️
src/common/src/config.rs 82.12% <25.00%> (-1.53%) ⬇️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@BugenZhao
Copy link
Member Author

@BugenZhao BugenZhao requested review from hzxa21 and fuyufjh June 2, 2023 15:25
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@BugenZhao BugenZhao added this pull request to the merge queue Jun 5, 2023
Merged via the queue into main with commit a504c40 Jun 5, 2023
@BugenZhao BugenZhao deleted the bz/verbose-await-tree-in-production branch June 5, 2023 05:12
zwang28 pushed a commit that referenced this pull request Jun 5, 2023
zwang28 pushed a commit that referenced this pull request Jun 5, 2023
kwannoel pushed a commit that referenced this pull request Jun 6, 2023
zwang28 pushed a commit that referenced this pull request Jun 8, 2023
lmatz pushed a commit that referenced this pull request Jun 25, 2023
lmatz added a commit that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Type: New feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants