Skip to content

Use may_exist in Hash Join #7938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #7289
lmatz opened this issue Feb 15, 2023 · 0 comments · Fixed by #7957
Closed
Tracked by #7289

Use may_exist in Hash Join #7938

lmatz opened this issue Feb 15, 2023 · 0 comments · Fixed by #7957
Assignees
Labels
type/perf Type: Performance.
Milestone

Comments

@lmatz
Copy link
Contributor

lmatz commented Feb 15, 2023

The refilling is most valuable when inserting a join key that does not exist before, and is less useful when the join key already exist. So it would be better is we can have a bloom filter API from storage, so that we can only write then the join key does not exist (in bloom filter).

Originally posted by @yuhao-su in #7393 (comment)

After #7489, we now can implement this strategy

@github-actions github-actions bot added this to the release-0.1.18 milestone Feb 15, 2023
@lmatz lmatz added open to contribution Issues that are open to contribution. type/perf Type: Performance. labels Feb 15, 2023
@fuyufjh fuyufjh removed the open to contribution Issues that are open to contribution. label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/perf Type: Performance.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants