Skip to content

Make Exchange be aware of the watermark #6050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #6042
soundOfDestiny opened this issue Oct 26, 2022 · 0 comments · Fixed by #6110
Closed
Tracked by #6042

Make Exchange be aware of the watermark #6050

soundOfDestiny opened this issue Oct 26, 2022 · 0 comments · Fixed by #6110
Assignees
@soundOfDestiny
Milestone
release-0.1.14

Comments

@soundOfDestiny
Copy link
Contributor

No description provided.

@soundOfDestiny soundOfDestiny mentioned this issue Oct 26, 2022
Open
22 tasks
@github-actions github-actions bot added this to the release-0.1.14 milestone Oct 26, 2022
@soundOfDestiny soundOfDestiny self-assigned this Oct 26, 2022
soundOfDestiny pushed a commit that referenced this issue Oct 30, 2022
feat(watermark): Make Exchange be aware of the watermark (close #6050)
84bb668
@soundOfDestiny soundOfDestiny mentioned this issue Oct 30, 2022
Merged
2 tasks
soundOfDestiny pushed a commit that referenced this issue Oct 30, 2022
feat(watermark): Make Exchange be aware of the watermark (close #6050)
350312c
soundOfDestiny pushed a commit that referenced this issue Nov 1, 2022
feat(watermark): Make Exchange be aware of the watermark (close #6050)
7aabf97
soundOfDestiny pushed a commit that referenced this issue Nov 1, 2022
feat(watermark): Make Exchange be aware of the watermark (close #6050)
f28a05c
mergify bot added a commit that referenced this issue Nov 2, 2022
@soundOfDestiny @BugenZhao @mergify
feat(watermark): Make Exchange be aware of the watermark (close #6050) (
c385383 
#6110)

* feat(watermark): Make Exchange be aware of the watermark (close #6050)

* Update src/stream/src/executor/mod.rs

Co-authored-by: Bugen Zhao <[email protected]>

* add some tests

* refactor

* refactor

* Update src/stream/src/executor/merge.rs

Co-authored-by: Bugen Zhao <[email protected]>

* add docs

* pop and eliminate all other watermarks with the same value

* use BTreeMap

* add comments

Co-authored-by: Bugen Zhao <[email protected]>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mergify mergify bot closed this as completed in #6110 Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soundOfDestiny soundOfDestiny

Labels
None yet
Projects
None yet
Milestone
release-0.1.14
Development

Successfully merging a pull request may close this issue.

feat(watermark): Make Exchange be aware of the watermark (close #6050) risingwavelabs/risingwave
1 participant
@soundOfDestiny