Skip to content

chore: remove RW_METRICS_LEVEL env #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

huangjw806
Copy link
Contributor

@huangjw806 huangjw806 commented Sep 8, 2023

What's changed and what's your intention?

risingwavelabs/risingwave#12099

The above PR changes the default value of this environment variable to 'info', 1 is an invalid value.

Checklist

  • I have written the necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@huangjw806 huangjw806 requested a review from arkbriar September 8, 2023 02:16
Copy link
Collaborator

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huangjw806 huangjw806 changed the title chore: update RW_METRICS_LEVEL env to 'info' chore: remove RW_METRICS_LEVEL env Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #500 (9cb667d) into main (8d76221) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #500      +/-   ##
==========================================
- Coverage   67.83%   67.74%   -0.10%     
==========================================
  Files          27       27              
  Lines        4275     4263      -12     
==========================================
- Hits         2900     2888      -12     
  Misses       1325     1325              
  Partials       50       50              
Flag Coverage Δ
unittests 67.74% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/factory/risingwave_object_factory.go 89.11% <ø> (-0.09%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

📢 Have feedback on the report? Share it here.

@huangjw806 huangjw806 added this pull request to the merge queue Sep 8, 2023
Merged via the queue into main with commit 31cbfb1 Sep 8, 2023
@huangjw806 huangjw806 deleted the jianwei/update-rw-metrics-level-env branch September 8, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants