Skip to content

Replace NodeJS methods introduced in #48 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hendrikbursian opened this issue Aug 16, 2020 · 1 comment
Open

Replace NodeJS methods introduced in #48 #50

hendrikbursian opened this issue Aug 16, 2020 · 1 comment

Comments

@hendrikbursian
Copy link
Contributor

Hey its me again!

After implementing the fix for #48 I noticed that even if the generation of the pages during build time went fine and gave the proper results, when the javascript loads in the browser it didn't work.

That is due to the NodeJS methods I used.

They need to be replaced with native javascript so browsers can run the code to.

I wasnt aware of that. I prepare another MR to fix it in its entirety :)
hendrikbursian added a commit to hendrikbursian/gridsome-plugin-pwa that referenced this issue Aug 16, 2020
@hendrikbursian
Replace NodeJS methods with native javascript
fb4621f 
Fixes rishabh3112#50

When fixing the path generation for "msapplication-TileImage" rishabh3112#48 NodeJS methods were used.
This commit fixes the usage of NodeJS which is not available in the browser.
hendrikbursian added a commit to hendrikbursian/gridsome-plugin-pwa that referenced this issue Aug 16, 2020
@hendrikbursian
Replace NodeJS methods with native javascript
25ca16f 
Fixes rishabh3112#50

When fixing the path generation for "msapplication-TileImage" rishabh3112#48 NodeJS methods were used.
This commit fixes the usage of NodeJS which is not available in the browser.
@hendrikbursian
Copy link
Contributor Author

hendrikbursian commented Aug 16, 2020 •
edited
Loading

Okay, did it!
It would be great if you could publish the package when you merge it so we can use it from the npm repo ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hendrikbursian