Skip to content

feat(llvm-test): upload riscv.json to github #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Conversation

AFOliveira
Copy link
Collaborator

riscv.json is llvm-tablegen for risc-v.
Uploading it to github actions, allows users to download it, instead of building it locally.

riscv.json is llvm-tablegen for risc-v.
Uploading it to github actions, allows users to download it, instead of
building it locally.

Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira AFOliveira force-pushed the AFOliveira/uploadCI branch from 1c8fc9f to 3a4a552 Compare May 7, 2025 12:51
@ThinkOpenly
Copy link
Collaborator

riscv.json is llvm-tablegen for risc-v. Uploading it to github actions, allows users to download it, instead of building it locally.

Do we provide a link to this file somewhere?

@AFOliveira
Copy link
Collaborator Author

riscv.json is llvm-tablegen for risc-v. Uploading it to github actions, allows users to download it, instead of building it locally.

Do we provide a link to this file somewhere?

Yes, it is embedded in the action. From what I could grasp, this is standard for the upload and did not document this part.

See
image

@AFOliveira AFOliveira enabled auto-merge May 7, 2025 13:05
@ThinkOpenly
Copy link
Collaborator

riscv.json is llvm-tablegen for risc-v. Uploading it to github actions, allows users to download it, instead of building it locally.

Do we provide a link to this file somewhere?

Yes, it is embedded in the action.

I'm confused. Are we expecting users to download this file from the action artifacts?

@AFOliveira
Copy link
Collaborator Author

I'm confused. Are we expecting users to download this file from the action artifacts?

It's not about expecting users to download it. This artifact is generated by compiling LLVM, which is a time-consuming process and requires a reasonably capable machine. It's mainly useful for those who want to compare against LLVM locally or fix errors that appear in the CI (like in my case). Downloading it from the action artifacts is just a convenience for UDB developers to avoid the need to build LLVM locally. Therefore, it can be linked in other way, but I don't think it should have a static location, as it's not an output but rather a debugging aid for developers.

@AFOliveira AFOliveira added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit de3ea3e May 9, 2025
17 checks passed
@AFOliveira AFOliveira deleted the AFOliveira/uploadCI branch May 9, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants