Skip to content

Improved caching to improve performance of test:regress by about 2X. #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

james-ball-qualcomm
Copy link
Collaborator

No description provided.

@james-ball-qualcomm
Copy link
Collaborator Author

@dhower-qc, spent a hours on trying to debug why the cpp_hart regression test is failing in this and my other recent PRs.

Can you please take a look? Here's the error message:

/workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task_manager.rb:59:in `[]': Don't know how to build task '/workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/cfgs/rv64/inst.hxx.unformatted' (See the list of available tasks with `do --tasks`) (RuntimeError)
Did you mean?  /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/bitfield.hxx.unformatted
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/hart_factory.hxx.unformatted
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/enum.hxx.unformatted
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/db_data.hxx.unformatted
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/libhart.h.unformatted
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/inst.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/defines.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/src/enum.cxx.unformatted
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/bitfield.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/bits.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/src/db_data.cxx.unformatted
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/config_validator.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/renode_imports.h
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/util.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/stop_reason.h
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/xregister.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/renode_map.h
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/version.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/soc_model.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/csr.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/iss_soc_model.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/bits-yaml.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/cpp_exceptions.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/memory.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/hart.hpp
               /workspaces/riscv-unified-db/gen/cpp_hart_gen/rv64_RelWithDebInfo/include/udb/elf_reader.hpp
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:405:in `[]'
	from /workspaces/riscv-unified-db/backends/cpp_hart_gen/tasks.rake:312:in `block (3 levels) in <top (required)>'
	from /workspaces/riscv-unified-db/backends/cpp_hart_gen/tasks.rake:310:in `each'
	from /workspaces/riscv-unified-db/backends/cpp_hart_gen/tasks.rake:310:in `block (2 levels) in <top (required)>'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:281:in `block in execute'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:281:in `each'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:281:in `execute'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:219:in `block in invoke_with_call_chain'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:199:in `synchronize'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:199:in `invoke_with_call_chain'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:243:in `block in invoke_prerequisites'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:241:in `each'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:241:in `invoke_prerequisites'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:218:in `block in invoke_with_call_chain'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:199:in `synchronize'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:199:in `invoke_with_call_chain'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/task.rb:188:in `invoke'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/application.rb:188:in `invoke_task'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/application.rb:138:in `block (2 levels) in top_level'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/application.rb:138:in `each'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/application.rb:138:in `block in top_level'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/application.rb:147:in `run_with_threads'
	from /workspaces/riscv-unified-db/.home/.gems/ruby/3.2.0/gems/rake-13.2.1/lib/rake/application.rb:132:in `top_level'
	from -e:1:in `<main>'
Running with 1 job(s)

Copy link
Collaborator

@ThinkOpenly ThinkOpenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With my "emerging" Ruby skills, seems basically OK. Just some spell-os noted inline.

@james-ball-qualcomm james-ball-qualcomm dismissed ThinkOpenly’s stale review April 29, 2025 20:43

Made the changes you requested. Not sure why Github still thinks this isn't resolved.

@james-ball-qualcomm james-ball-qualcomm added this pull request to the merge queue Apr 29, 2025
Merged via the queue into main with commit e2d13ef Apr 29, 2025
17 checks passed
@james-ball-qualcomm james-ball-qualcomm deleted the 669-regression-test-is-much-slower-for-same-artifacts-after-cpp_hart-merge branch April 29, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression test is much slower for same artifacts after cpp_hart merge
3 participants