Skip to content

[gcloud-sqlproxy] fix #145 use sha1sum instead of randAlphaNum #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 20, 2023

Conversation

danyworks
Copy link
Contributor

What this PR does / why we need it:
for persistance of random suffix, used by instanceShortName. the function randAlphaNum was previously used, is now replaced with a trimmed sha1sum, that is 9 characters long.

This sha1sum is generated using instance name so it remains consistent across multiple calls, as long as the instance name does not change.

Which issue this PR fixes:
fixes #145

Special notes for your reviewer:
I did bumped the chart version, but i guess the bug is in 0.25.3 so it is better to overwrite the version
instead of bumping it.
I bumped it also, so the linter does not create issues.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped, is mandatory for any chart changes
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [gcloud-sqlproxy])

@rimusz
Copy link
Owner

rimusz commented Oct 20, 2023

@danyworks please resolve merge conflicts, thanks

@rimusz
Copy link
Owner

rimusz commented Oct 20, 2023

@danyworks please resolve chart lint issues, thanks

@rimusz rimusz merged commit daa840e into rimusz:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newest version doesn't work 0.25.3
3 participants