[gcloud-sqlproxy] fix #145 use sha1sum instead of randAlphaNum #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
for persistance of random suffix, used by instanceShortName. the function randAlphaNum was previously used, is now replaced with a trimmed sha1sum, that is 9 characters long.
This sha1sum is generated using instance name so it remains consistent across multiple calls, as long as the instance name does not change.
Which issue this PR fixes:
fixes #145
Special notes for your reviewer:
I did bumped the chart version, but i guess the bug is in 0.25.3 so it is better to overwrite the version
instead of bumping it.
I bumped it also, so the linter does not create issues.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[gcloud-sqlproxy]
)