fix: fix simplification so that a/(bc) = (a/b)/c #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, a/(bc) = (a/b)*c
|
antalsz
force-pushed
the
441-div-by-mul-simplification
branch
from
5de4684 to
bc97fb9
Compare
jselig-rigetti
approved these changes
Mar 5, 2025
| "4 / (2 * x)", | ||
| "2 / x" | ||
| } | ||
|
|
||
| // TODO doesn't fully simplify in a reasonable amount of recursion | ||
| // test_simplify! { | ||
| // the_big_one, |
There was a problem hiding this comment.
we want the big one!!
There was a problem hiding this comment.
That's what I've been working on recently, actually! Fingers crossed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, expression simplification will try to simplify
a / (b * c)to(a / b) / c.Previously, it would try to simplify to
(a / b) * cinstead.(Expression simplification already correctly simplifies
(x * y) / ztox * (y / z).)