Skip to content

feat!: Update pyQuil, drop support for Python 3.8, enable support for Python 3.13 #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 15, 2025

Conversation

MarquessV
Copy link
Contributor

@MarquessV MarquessV commented Oct 18, 2024

closes #18

The CI checks for Python 3.8 have been replaced with checking Python 3.12. I will update the required checks once this PR is approved.

@BatmanAoD BatmanAoD force-pushed the 18-update-pyquil branch 2 times, most recently from 7252f7a to f392457 Compare January 3, 2025 05:21
@BatmanAoD
Copy link
Contributor

The original version of this added a mypy ignore because the interface doesn't actually match the QuantumAbstractMachine defined in PyQuil, but that seems incorrect to me, so we should figure out how that divergence occurred and whether this library or PyQuil's interface needs to change.

@BatmanAoD
Copy link
Contributor

The run_batch function has existed since the initial commit. Maybe we need to keep that, with the existing API, and also implement the new execute_with_memory_map_batch function?

@BatmanAoD BatmanAoD force-pushed the 18-update-pyquil branch 2 times, most recently from 0721919 to 9329cde Compare January 15, 2025 20:49
@BatmanAoD
Copy link
Contributor

I am making the APIs of both AzureQuantumComputer and AzureQuantumMachine as compatible as possible with QuantumComputer and QAM, respectively. The Azure classes still must use the AzureProgram type rather than Program or EncryptedProgram, but I've added comments explaining that, and applied a more narrow mypy exception for each function.

Copy link
Contributor

@jselig-rigetti jselig-rigetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run_batch function has existed since the initial commit. Maybe we need to keep that, with the existing API, and also implement the new execute_with_memory_map_batch function?

Is this why run_batch was removed entirely? Would it be a problem to alias it to run_with_memory_map_batch?

Overall LGTM though 👍 don't forget to make this breaking with feat!:

@BatmanAoD BatmanAoD changed the title feat: Update pyQuil, drop support for Python 3.8, enable support for Python 3.13 feat!: Update pyQuil, drop support for Python 3.8, enable support for Python 3.13 Jan 15, 2025
@BatmanAoD
Copy link
Contributor

@jselig-rigetti run_batch was removed because the memory_map format doesn't match the current format (each map value is a list-of-lists, where the "outer" list corresponds to the number of execution configurations), so making it an alias would be a breaking change anyway.

@BatmanAoD BatmanAoD enabled auto-merge (squash) January 15, 2025 22:31
@BatmanAoD BatmanAoD merged commit d1bd6b0 into main Jan 15, 2025
18 checks passed
@BatmanAoD BatmanAoD deleted the 18-update-pyquil branch January 15, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pyQuil
3 participants