-
Notifications
You must be signed in to change notification settings - Fork 1
feat!: Update pyQuil, drop support for Python 3.8, enable support for Python 3.13 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3eae079
to
f836400
Compare
7252f7a
to
f392457
Compare
f392457
to
70068b1
Compare
5c5424a
to
9c90a58
Compare
The original version of this added a mypy |
The |
0721919
to
9329cde
Compare
9329cde
to
450c6f0
Compare
I am making the APIs of both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
run_batch
function has existed since the initial commit. Maybe we need to keep that, with the existing API, and also implement the newexecute_with_memory_map_batch
function?
Is this why run_batch
was removed entirely? Would it be a problem to alias it to run_with_memory_map_batch
?
Overall LGTM though 👍 don't forget to make this breaking with feat!:
@jselig-rigetti |
closes #18
The CI checks for Python 3.8 have been replaced with checking Python 3.12. I will update the required checks once this PR is approved.