Fix pet-battle-api version bump on 2-create-alerts.md #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs/4-return-of-the-monitoring/2-create-alerts.md step 5) lab is not working because the pet-battle-api version bump is not done correctly. The instructions teach the student to bump to version 1.3.1, but this is the current version of the pet-battle-api chart at that point (the previous docs/3-revenge-of-the-automated-testing/5b-tekton.md lab bumps to that version, 1.3.1).
Because of this incorrect version bump, the PrometheusRule object in ArgoCD is not updated with the new alerts rules used on the lab as PetBattleMongoDBDiskUsage, the lab alert is not triggered and the lab fails.
The solution proposed in this PR is to perform a correct pet-battle-api chart version bump to
1.3.2. I have tested in my GLS TL500 lab that this solution fixes the problem. Many thanks in advance for the review @eformat .