Enable stateless Rulers #151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saswatamcode
commented
Feb 9, 2022
saswatamcode
force-pushed
the
stateless-rulers
branch
from
ba1ccdf to
1ea8db0
Compare
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
Signed-off-by: Saswata Mukherjee <[email protected]>
saswatamcode
force-pushed
the
stateless-rulers
branch
from
1ea8db0 to
094d498
Compare
matej-g
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Looking good @saswatamcode 👍 My only additional suggestion would be to drop ruler from --store in querier args, since it won't be exposing store API anymore, right?
Additionally, as we mention, it would be good to switch ruler from stateful set to deployment, since with stateless mode we have no need to run in stateful set, but this we can do separately later.
Signed-off-by: Saswata Mukherjee <[email protected]>
|
Thanks for catching this @ianbillett! 🙂 |
bill3tt
approved these changes
Mar 15, 2022
matej-g
added a commit
to matej-g/configuration
that referenced
this pull request
Mar 18, 2022
This reverts commit a90e443.
saswatamcode
added a commit
to saswatamcode/configuration
that referenced
this pull request
Mar 21, 2022
This reverts commit a90e443.
matej-g
pushed a commit
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
observatorium-metricsandmetric-federation-ruletemplateskube-thanosto latestAddresses MON-2128.
Note: These changes cannot be rolled out before Thanos v0.25, as support for specifying multiple remote_write targets was added after v0.24 (thanos#4927).