payload/rpm-ostree: Include program output in exception #6431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rpm-ostree container deployment path can fail for many reasons from networking to details in mount setup. What we really want is a proper API with progress out of bootc/ostree; I will work on that at some point. In the meantime though, just capture stderr on failure and include it in the payload installation error so people don't have to dig into `program.log` which is very obscure. Signed-off-by: Colin Walters <[email protected]> Cherry-picked from: 7d40d85 Resolves: RHEL-83926
|
/kickstart-tests --testtype smoke |
KKoukiou
added
the
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rpm-ostree container deployment path can fail for many reasons from networking to details in mount setup.
What we really want is a proper API with progress out of bootc/ostree; I will work on that at some point.
In the meantime though, just capture stderr on failure and include it in the payload installation error so people don't have to dig into
program.logwhich is very obscure.Signed-off-by: Colin Walters [email protected]
Cherry-picked from: 7d40d85
Resolves: RHEL-83926