Skip to content

fix: skip empty files #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix: skip empty files #71

merged 1 commit into from
Jan 22, 2025

Conversation

2color
Copy link
Contributor

@2color 2color commented Jan 21, 2025

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
In POSIX sh, set option pipefail is undefined. SC3040

set -eo pipefail

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

git config --global --add safe.directory $GITHUB_WORKSPACE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

FILES="$(git ls-files | ghglob ${INPUT_PATTERNS})"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [shellcheck] reported by reviewdog 🐶
In POSIX sh, echo flags are undefined. SC3037

IFS=$(echo -en "\n\b")

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

git config --global --add safe.directory $GITHUB_WORKSPACE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

FILES="$(git ls-files | ghglob ${INPUT_PATTERNS})"

@haya14busa haya14busa merged commit c5f7828 into master Jan 22, 2025
11 checks passed
Copy link
Contributor

🏷️ [bumpr] Next version:v1.20.2 Changes:v1.20.1...reviewdog:skip-empty

Copy link
Contributor

🚀 [bumpr] Bumped! New version:v1.20.2 Changes:v1.20.1...v1.20.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants