Skip to content

Avoid error due to deprecated ICM option #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Conversation

lobis
Copy link
Member

@lobis lobis commented Jan 16, 2023

lobis Ok: 12

In the latest release of Geant4 (v11.1.0) the ICM option appears to be deprecated, as it can be read in the release notes.

I have never used this option, I would love to know if anyone has some insight in this topic.

I modified the code to maintain compatilbity with older (10.4.3) version (I am not a fan of all this branching with #ifdef but...). I attempted to keep the original funtionality of the ICM option in my changes but I am not sure how to check it works correctly, or if it was working correctly in the first place anyway.

@jgalan
Copy link
Member

jgalan commented Jan 17, 2023

I don't think anyone will launch new simulations with Geant4 10.4. At least with the latest rest versions.

./installGeant4.sh scripts dictates the recommended version.

@lobis
Copy link
Member Author

lobis commented Jan 17, 2023

I don't think anyone will launch new simulations with Geant4 10.4. At least with the latest rest versions.

./installGeant4.sh scripts dictates the recommended version.

Yes but we still need to maintain compatibility right? that why we need to do all these branching. The pipeline explicitly tests the current version of the framework / restG4 works with 10.4.3 as it was decided at the time.

Anyway since I don't know how to check if this works correctly and probably nobody is using this option, I just added a comment to point to any future user to post an issue if this is a problem, or perhaps we could disable the option entirely.

@lobis lobis marked this pull request as ready for review January 17, 2023 10:52
@lobis lobis added the geant4-compatibility Remove deprecated interfaces or support new ones label Jan 17, 2023
Copy link
Contributor

@glorialuzon glorialuzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also have no experience with this "ICM" . Let's try to keep like that way for compatilbity with older geant4 versions

@lobis lobis merged commit 51dd631 into master Jan 17, 2023
@lobis lobis deleted the lobis-internal-conversion branch January 17, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
geant4-compatibility Remove deprecated interfaces or support new ones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants