fix bad visualization with default settings, update default "activateAllVolumes" to true #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lobis
changed the title
cmargalejo
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The visualizaiton does not work correctly unless the user activates all volumes, as the tracks will be clipped otherwise, and the particles won't exit the world volume (since its not activated, the step is not recorded).
I have updated the defaults so that all volumes are activated by default (previously this was the case if no volume was manually activated only). This way the visualization will work properly by default. I have also updated the corresponding examples to explicitly avoid activating all volumes, so that we don't have to modify validation values.