Skip to content

Remove nix #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2025
Merged

Remove nix #676

merged 10 commits into from
May 13, 2025

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented May 13, 2025

Nix obscured the fact that our linter was out-of-date so this PR update the linter and includes a bunch of linting fixes.


- name: Build resonate
run: |
go build -o resonate main.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there is a way to use the artifacts of the build step. That way we don't need to build twice. We can do it on different PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we can use the cache, but also agree, different PR

@dfarr dfarr merged commit a756edc into main May 13, 2025
28 checks passed
@dfarr dfarr deleted the remove-nix branch May 13, 2025 20:12
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 48.14815% with 70 lines in your changes missing coverage. Please review.

Project coverage is 52.14%. Comparing base (3ff2ac1) to head (604fc8d).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/promises/promises.go 0.00% 24 Missing ⚠️
cmd/schedules/schedules.go 0.00% 22 Missing ⚠️
cmd/projects/scaffold.go 0.00% 6 Missing ⚠️
internal/app/subsystems/api/http/task.go 0.00% 3 Missing ⚠️
internal/util/util.go 25.00% 2 Missing and 1 partial ⚠️
test/dst/bc_validator.go 0.00% 3 Missing ⚠️
cmd/dst/issue.go 0.00% 2 Missing ⚠️
internal/app/coroutines/createPromise.go 83.33% 2 Missing ⚠️
test/dst/validator.go 33.33% 0 Missing and 2 partials ⚠️
cmd/projects/projects.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   52.25%   52.14%   -0.12%     
==========================================
  Files         133      133              
  Lines       14409    14442      +33     
==========================================
+ Hits         7530     7531       +1     
- Misses       6418     6448      +30     
- Partials      461      463       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lucperkins
Copy link
Contributor

@dfarr @avillega As the person who set up Nix in this repo (as a favor for some old industry pals), I'd love to know in which ways it didn't meet your needs!

@avillega
Copy link
Contributor

Hey @lucperkins. We don't think our project benefits from Nix, it is a simple Go project without many dependencies, on the other hand we were getting slowed down by nix, no one in the team is proficient in nix and any change that required updating our small set of dependencies was taking way longer than what we wanted. Without nix we can let dependabot take care of those. Basically the extra complexity was not worth it based on our project needs.

@lucperkins
Copy link
Contributor

@avillega Makes sense, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants