-
Notifications
You must be signed in to change notification settings - Fork 39
Remove nix #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove nix #676
Conversation
|
||
- name: Build resonate | ||
run: | | ||
go build -o resonate main.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember there is a way to use the artifacts of the build step. That way we don't need to build twice. We can do it on different PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we can use the cache, but also agree, different PR
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
- Coverage 52.25% 52.14% -0.12%
==========================================
Files 133 133
Lines 14409 14442 +33
==========================================
+ Hits 7530 7531 +1
- Misses 6418 6448 +30
- Partials 461 463 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey @lucperkins. We don't think our project benefits from Nix, it is a simple Go project without many dependencies, on the other hand we were getting slowed down by nix, no one in the team is proficient in nix and any change that required updating our small set of dependencies was taking way longer than what we wanted. Without nix we can let dependabot take care of those. Basically the extra complexity was not worth it based on our project needs. |
@avillega Makes sense, thanks for the explanation! |
Nix obscured the fact that our linter was out-of-date so this PR update the linter and includes a bunch of linting fixes.