Skip to content

DST fixes related to timeouts and callbacks with promiseId==rootId #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2025

Conversation

avillega
Copy link
Contributor

Fixes some more dst failures but not all of them

@avillega avillega requested a review from dfarr March 24, 2025 19:05
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.31%. Comparing base (9547225) to head (8251068).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/dst/validator.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   52.34%   52.31%   -0.04%     
==========================================
  Files         133      133              
  Lines       14401    14402       +1     
==========================================
- Hits         7538     7534       -4     
- Misses       6401     6408       +7     
+ Partials      462      460       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@avillega avillega merged commit e2d4531 into main Mar 24, 2025
6 checks passed
@avillega avillega deleted the avillega/dst-fix branch March 24, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants