Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(retry): export retry so users can configure the retry policy #96

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

guergabo
Copy link
Contributor

@guergabo guergabo commented Apr 3, 2024

First thing users will try to configure is the retry policy. This was already requested by an initial user I spoke to.

Changes

  • Exposes retry object so users can configure the retry policy.

@guergabo guergabo self-assigned this Apr 3, 2024
@guergabo guergabo requested a review from dfarr April 3, 2024 19:40
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.63%. Comparing base (b48fe99) to head (8b52527).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   80.63%   80.63%           
=======================================
  Files          22       22           
  Lines        1188     1188           
  Branches      290      306   +16     
=======================================
  Hits          958      958           
- Misses        220      230   +10     
+ Partials       10        0   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guergabo guergabo changed the title fix(retry): export retry so users can confugre the retry policy fix(retry): export retry so users can configure the retry policy Apr 3, 2024
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🎉

@guergabo guergabo merged commit 99d76ba into main Apr 3, 2024
2 checks passed
@guergabo guergabo deleted the retry branch April 3, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants