Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak DST tests #44

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Tweak DST tests #44

merged 2 commits into from
Feb 9, 2024

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Feb 9, 2024

Moves the random failure down to local execution and only throws an exception after we create the durable promise. This prevents the possibility of failure before creating the promise (which may already be completed) which can result in non-progressing executions.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (468eeee) 61.92% compared to head (188910a) 62.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   61.92%   62.45%   +0.52%     
==========================================
  Files          18       20       +2     
  Lines         851      863      +12     
  Branches      222      225       +3     
==========================================
+ Hits          527      539      +12     
  Misses        296      296              
  Partials       28       28              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr merged commit 951ed17 into main Feb 9, 2024
@dfarr dfarr deleted the feature/dst branch February 9, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants