Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locks and Schedules Create API fix #36

Merged
merged 3 commits into from
Feb 1, 2024
Merged

Locks and Schedules Create API fix #36

merged 3 commits into from
Feb 1, 2024

Conversation

vaibhawvipul
Copy link
Contributor

  1. fix locks tryAcquire
  2. fix schedules create

2. fix schedules create
@vaibhawvipul vaibhawvipul requested a review from dfarr February 1, 2024 08:20
@vaibhawvipul vaibhawvipul self-assigned this Feb 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (13fd35d) 59.05% compared to head (395b8d0) 58.75%.

Files Patch % Lines
lib/core/stores/remote.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
- Coverage   59.05%   58.75%   -0.30%     
==========================================
  Files          16       16              
  Lines         784      788       +4     
  Branches      190      192       +2     
==========================================
  Hits          463      463              
- Misses        294      298       +4     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr merged commit 9f7e22e into main Feb 1, 2024
@dfarr dfarr deleted the lock-scheduler-bug-fix branch February 1, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants