Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedules for stores #21

Merged
merged 45 commits into from
Jan 19, 2024
Merged

Schedules for stores #21

merged 45 commits into from
Jan 19, 2024

Conversation

vaibhawvipul
Copy link
Contributor

@vaibhawvipul vaibhawvipul commented Jan 10, 2024

  1. adding schedule type
  2. schedule methods in store interface
  3. interfaces implemented in remote store
  4. Control loop in local promise store
  5. implementation of local promise store

2. schedule methods in store interface
3. interfaces implemented in remote store
@vaibhawvipul vaibhawvipul requested a review from dfarr January 10, 2024 05:37
@vaibhawvipul vaibhawvipul self-assigned this Jan 10, 2024
@vaibhawvipul vaibhawvipul changed the title Schedules for stores [WIP] Schedules for stores Jan 10, 2024
@vaibhawvipul vaibhawvipul marked this pull request as draft January 10, 2024 05:37
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 145 lines in your changes are missing coverage. Please review.

Comparison is base (e88f1f3) 67.00% compared to head (d71b9b6) 63.49%.

Files Patch % Lines
lib/core/stores/remote.ts 13.26% 78 Missing and 7 partials ⚠️
lib/core/stores/local.ts 55.17% 25 Missing and 1 partial ⚠️
lib/core/promise.ts 11.11% 8 Missing ⚠️
lib/core/storages/memory.ts 75.75% 8 Missing ⚠️
lib/core/store.ts 22.22% 7 Missing ⚠️
lib/core/schedule.ts 14.28% 6 Missing ⚠️
lib/core/storages/withTimeout.ts 61.53% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
- Coverage   67.00%   63.49%   -3.51%     
==========================================
  Files          18       19       +1     
  Lines         597      726     +129     
  Branches      143      174      +31     
==========================================
+ Hits          400      461      +61     
- Misses        184      249      +65     
- Partials       13       16       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaibhawvipul vaibhawvipul requested a review from dfarr January 19, 2024 16:14
@dfarr dfarr merged commit 13b7217 into main Jan 19, 2024
@dfarr dfarr deleted the scheduler-crud-store branch January 19, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants