Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): update remote store to new promise rest api #18

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Conversation

guergabo
Copy link
Contributor

@guergabo guergabo commented Dec 20, 2023

Changes

  • fix remote store to work with new promise rest api

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (b3e16cc) 68.43% compared to head (6063947) 68.43%.

Files Patch % Lines
lib/core/stores/remote.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   68.43%   68.43%           
=======================================
  Files          17       17           
  Lines         583      583           
  Branches      128      128           
=======================================
  Hits          399      399           
  Misses        174      174           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guergabo guergabo requested a review from dfarr December 20, 2023 22:40
@guergabo guergabo requested a review from dfarr December 20, 2023 22:51
@guergabo guergabo merged commit 4c9cb11 into main Dec 20, 2023
@guergabo guergabo deleted the rest branch December 20, 2023 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants