Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for Function Call types #129

Merged
merged 4 commits into from
Jul 2, 2024
Merged

Add initial support for Function Call types #129

merged 4 commits into from
Jul 2, 2024

Conversation

avillega
Copy link
Contributor

@avillega avillega commented Jul 2, 2024

This PR implements the first part of this proposal #120. It focuses mostly in bringing the FC concepts to the api surface, future PR will bring this concept deeper into the architecture.

avillega added 2 commits June 27, 2024 18:26
Initial implementation of TFC for `resonate.run`
@avillega avillega requested a review from dfarr July 2, 2024 17:50
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 96.49123% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.71%. Comparing base (4da10af) to head (ebc77b7).

Files Patch % Lines
lib/resonate.ts 90.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   82.44%   82.71%   +0.27%     
==========================================
  Files          22       23       +1     
  Lines        1401     1429      +28     
  Branches      377      384       +7     
==========================================
+ Hits         1155     1182      +27     
- Misses        240      241       +1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: David Farr <[email protected]>
@avillega avillega merged commit 7cf1db2 into main Jul 2, 2024
2 checks passed
@avillega avillega deleted the avillega/fcs branch July 2, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants