Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync and wait to durable promise class #112

Merged
merged 1 commit into from
May 8, 2024

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented May 7, 2024

Sync and wait can be used to join on the completion of a durable promise. Sync resolves when the durable promise completed, wait resolves to the value (or throws a corresponding error) when the durable promise is completed.

Sync and wait can be used to join on the completion of a durable
promise. Sync resolves when the durable promise completed, wait
resolves to the value (or throws a corresponding error) when the
durable promise is completed.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 80.74%. Comparing base (93ad425) to head (d4e4b4d).

Files Patch % Lines
lib/core/promises/promises.ts 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
- Coverage   81.17%   80.74%   -0.44%     
==========================================
  Files          22       22              
  Lines        1307     1319      +12     
  Branches      331      355      +24     
==========================================
+ Hits         1061     1065       +4     
- Misses        238      246       +8     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr merged commit 308929e into main May 8, 2024
2 checks passed
@dfarr dfarr deleted the feature/durable-promise-wait-sync branch May 8, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants