Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createdOn time to context #107

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Add createdOn time to context #107

merged 1 commit into from
Apr 29, 2024

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Apr 26, 2024

This time indicates the time that the durable promise was created, if an execution has opted out of a durable promise the time that the invocation was created will be used instead.

@dfarr
Copy link
Member Author

dfarr commented Apr 26, 2024

What is your preferred term?

  • createdOn (what we use in the server/db)
  • createdAt
  • something else?

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 81.17%. Comparing base (18fe922) to head (176e288).

Files Patch % Lines
lib/async.ts 0.00% 2 Missing ⚠️
lib/generator.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   81.32%   81.17%   -0.15%     
==========================================
  Files          22       22              
  Lines        1296     1307      +11     
  Branches      348      327      -21     
==========================================
+ Hits         1054     1061       +7     
- Misses        234      246      +12     
+ Partials        8        0       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr merged commit cd26621 into main Apr 29, 2024
2 checks passed
@dfarr dfarr deleted the feature/createdOn branch April 29, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants