Skip to content

Shore up Resonate errors #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2025
Merged

Shore up Resonate errors #245

merged 5 commits into from
May 9, 2025

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented May 9, 2025

Preserve server information when a remote store request error occurs.

resonate.errors.errors.ResonateStoreError: [300.40900] The specified promise already exists
[
  {
    "@type": "RequestError",
    "message": "Request errors are not retryable since they are caused by invalid client requests",
    "domain": "request",
    "metadata": {
      "url": "https://docs.resonatehq.io/reference/error-codes#40900"
    }
  }
]

resonate.errors.errors.ResonateStoreError: [300.40400] The specified promise was not found
[
  {
    "@type": "RequestError",
    "message": "Request errors are not retryable since they are caused by invalid client requests",
    "domain": "request",
    "metadata": {
      "url": "https://docs.resonatehq.io/reference/error-codes#40400"
    }
  }
]

Additionally:

  • set the cause for a ResonateShutdownError and use new method shutdown instead of step
  • retry policies now handle attempt 0 (initial attempt)

@dfarr
Copy link
Member Author

dfarr commented May 9, 2025

We also need to recreate the web pages for our errors or remove them from the server error messages

Tomperez98
Tomperez98 previously approved these changes May 9, 2025
Also changing out error codes to two digits to avoid confusion
with http error codes.
@Tomperez98 Tomperez98 self-requested a review May 9, 2025 15:55
@dfarr dfarr merged commit 4599fb4 into main May 9, 2025
4 checks passed
@dfarr dfarr deleted the resonate-errors branch May 9, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants