Skip to content

Change timeout option from absolute to relative time #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented May 6, 2025

No description provided.

Tomperez98
Tomperez98 previously approved these changes May 6, 2025
Copy link
Contributor

@avillega avillega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something we need to do in this PR, but if the bridge has an instance of clock now it should be used in other places where we use time, like when putting stuff in the delay queue.

@dfarr
Copy link
Member Author

dfarr commented May 7, 2025

Not something we need to do in this PR, but if the bridge has an instance of clock now it should be used in other places where we use time, like when putting stuff in the delay queue.

I actually decided to remove clock from the bridge, the bridge is free to look at the time and the scheduler/simulator use the clock (but the scheduler uses it indirectly via the dependencies).

@dfarr dfarr merged commit 1ab2c83 into main May 7, 2025
4 checks passed
@dfarr dfarr deleted the relative-timeout branch May 7, 2025 18:23
@Tomperez98 Tomperez98 linked an issue May 8, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify timeout in relative terms
3 participants